This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Introducing JavaArray class #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now ByteArray and ShortArray can be replaced with a single templated superclass. Goodbye duplicated code! Tests for ByteArray/ShortArray are broken by this change and disabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kaaes I found the branch we were talking about, it was on my home workstation. The general idea seems sound, however the tests for ByteArray and ShortArray are disabled (I don't remember exactly why they are broken, but apparently they are).
Looking at the implementation of this class, it seems that it will only work for primitive types. However I think that we could subclass this and use std::vector as the storage container without too much trouble. Let's talk more about this next time we're at the office.